Fix top bar on mobile and remove Notion branding#83
Open
pranaygp wants to merge 1 commit intostephenou:masterfrom
Open
Fix top bar on mobile and remove Notion branding#83pranaygp wants to merge 1 commit intostephenou:masterfrom
pranaygp wants to merge 1 commit intostephenou:masterfrom
Conversation
This PR fixes the top bar on mobile by 1. Removing the "three dots" menu that lets you duplicate the page or log into notion. (it's now `div.notion-topbar-mobile > div:nth-child(5)`) 2. Adding some padding to the dark mode slider, which was flush with the screen. It now looks like this (can be seen on https://sayhurro.com) It also removes some notion branding: 1. "@notionhq" from twitter:site 2. "Notion" from og:site_name 3. When sharing a link, it removes the default notion "og:image" and "twitter:image" We could use a new PR to add a for input to let people use their own hosted og:image instead or simply deleting the notion image. On https://sayhurro.com, I've modified my script to use an image hosted directly through notion
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the top bar on mobile by
div.notion-topbar-mobile > div:nth-child(5))It now looks like this (can be seen on https://sayhurro.com)
It also removes some notion branding:
We could use a new PR to add a for input to let people use their own hosted og:image instead or simply deleting the notion image. On https://sayhurro.com, I've modified my script to use an image hosted directly through notion